Update Application.cpp #1402
Annotations
4 errors and 22 warnings
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax)
Process completed with exit code 1.
|
|
Cpplint
Process completed with exit code 1.
|
|
Clang-tidy:
src/Gui/Application.cpp#L74
'GuiInitScript.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy
Process completed with exit code 1.
|
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Gui/Application.cpp#L2297
QTimer::singleShot(0, &mw, SLOT(delayedStartup())); <--Consider using Functor-Based Connections
|
|
Cpplint:
src/Gui/Application.cpp#L27
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L28
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L29
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L30
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L31
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L32
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L33
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L34
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L35
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Cpplint:
src/Gui/Application.cpp#L36
Found C system header after other header. Should be: Application.h, c system, c++ system, other. [build/include_order] [4]
|
|
Clazy
fatal error: 'GuiInitScript.h' file not found
|
|
Clang-tidy:
src/Gui/Application.cpp#L146
constructor does not initialize these fields: map [cppcoreguidelines-pro-type-member-init]
|
|
Clang-tidy:
src/Gui/Application.cpp#L154
do not use const_cast [cppcoreguidelines-pro-type-const-cast]
|
|
Clang-tidy:
src/Gui/Application.cpp#L162
do not use const_cast [cppcoreguidelines-pro-type-const-cast]
|
|
Clang-tidy:
src/Gui/Application.cpp#L184
class 'ApplicationP' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
|
Clang-tidy:
src/Gui/Application.cpp#L186
constructor does not initialize these fields: documents, passive [cppcoreguidelines-pro-type-member-init]
|
|
Clang-tidy:
src/Gui/Application.cpp#L220
32 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
Clang-tidy:
src/Gui/Application.cpp#L225
variable 'o' is not initialized [cppcoreguidelines-init-variables]
|
|
Clang-tidy:
src/Gui/Application.cpp#L225
variable name 'o' is too short, expected at least 2 characters [readability-identifier-length]
|
|
Clang-tidy:
src/Gui/Application.cpp#L226
do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg]
|
|
Clang-tidy:
src/Gui/Application.cpp#L226
implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
|
Loading