Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate jni bindings #1380

Closed
wants to merge 8 commits into from

Conversation

midepeter
Copy link

This PR is to realated to initial !1327 for generating java bindings for the ach library

This commit gives a benchmark report on the use of '[]*ach.File' and '[]ach.File'. It intend to show the improvement in passing by values instead of passing by reference
this commit creates javainterop package that ports functions from the general moov/ach package that does not align with the gobind rules for java jni bindings generation. It does this to be able to release a proper generated code for java apis to all the ach library.
@adamdecaf
Copy link
Member

Can you include only the changes for JNI interop in this PR?

javainterop/nextEntry.go Outdated Show resolved Hide resolved
@midepeter
Copy link
Author

Yes, that was what I intended to do ..

I think I had some commit issues … not sure why the commits mixed up but I fixed it up manually.

javainterop/nextEntry.go Outdated Show resolved Hide resolved
This commit ports exported types and methods to a single javainterop package to allow for ease generation of go bindings to allow for java application to be largely supported. It also updates the github actions workflow to generate the binding on push to master branches by access the 'make java' command in the makeFile
@midepeter
Copy link
Author

@adamdecaf

could you help take a look at the update. Thank you

@midepeter midepeter requested a review from adamdecaf March 6, 2024 19:17
@midepeter
Copy link
Author

@adamdecaf

Trust you are doing great.

Hopefully this passes the pending checks but i need a review from you on what i did to know if it fits for merging or if there is something more to do.

Thank you.

@midepeter
Copy link
Author

@adamdecaf

The ubuntu build is failing due to the test coverage. I though since we were porting the library the unit testing was not compulsory. I am not sure what I should do in this case.

@midepeter midepeter closed this Apr 1, 2024
@jason53
Copy link

jason53 commented Apr 11, 2024

@adamdecaf were these changes never merged in? i am just following up from our discussion. #1373 (reply in thread)

@adamdecaf
Copy link
Member

Correct they were not merged in. We still need to figure out a way to setup types/classes so the JNI layer supports them all.

I've tried another way but there are tons of unsupported classes, which is annoying. See #1406

@adamdecaf adamdecaf added this to the v2 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants