Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atto_styles: Try parent node if no class attribute when removing styles #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tonyjbutler
Copy link

This fixes a bug where attempting to remove a particular style sometimes fails.

@abias
Copy link
Member

abias commented Sep 26, 2018

Hi Tony,

thank you for this pull request and sorry for your patience with me coming back to you.

Could you please give me some background information / steps to reproduce which wrong behavior this pull request tries to solve?

Thanks,
Alex

@tonyjbutler
Copy link
Author

Hi Alex,

To be honest I can't remember the exact conditions necessary to reproduce this, but I think if you apply multiple styles to the same text you can get into a situation where nested elements are created, with different classes applied to each, and then only the class attribute on the innermost element can be removed with the button so you end up having to edit the HTML directly to get rid of them all.

Hope this helps.

Thanks,
Tony

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants