Apply PageUnit to clip regions. #745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `PageUnit` was being ignored when applying/calculating clips. Adds a `gdip_get_page_transform` function which combines the `clip_matrix` and `PageUnit` scaling (together with its inverse in `gdip_get_inverse_page_transform`) and uses this when setting the clip region and calculating clip bounds. Also adds tests for these operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this repo is dead, but maybe this will be useful to someone...
Previously
PageUnitwas being ignored when applying/calculating clips. Adds agdip_get_page_transformfunction which combines theclip_matrixandPageUnitscaling (together with its inverse ingdip_get_inverse_page_transform) and uses this when setting the clip region and calculating clip bounds.Also adds tests for these operations.
NOTE: This does not implement support for
PageScale; I assume this should just be a simple additional scaling step applied to the page transform but I didn't need support for this at this point.