Keeping track of temporary files created by GdipPrivateAddMemoryFont #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and clean them when the GpFontCollection is destoryed
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #690.
I've added a list of strings that should go along with the
GpFontCollection, this list are the temporary files created by theGdipPrivateAddMemoryFontfunction.When
Disposeis called by C# code,GdipDeletePrivateFontCollectionshould go through the list andremoves all temp files created.There are ways to get files associated with an
FcConfig, however, it will be hard to distinguish between files added usingGdipPrivateAddMemoryFontor files managed by the user added throughGdipPrivateAddFontFile, so I guess keeping a list of strings for later deletion is still a good solution.