GODRIVER-1778 Reject HeartbeatFrequencyMS of less than 500ms #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyjwang
changed the title
API Change ReportNo changes found! |
|
Possible Follow-Ups:
|
prestonvasquez
requested changes
Sep 27, 2024
| @@ -45,7 +45,7 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| defaultHeartbeatInterval = 50 * time.Millisecond | |||
| defaultHeartbeatInterval = 500 * time.Millisecond | |||
There was a problem hiding this comment.
What is the history of the original 50ms default? Does the 500ms requirement conflict with legacy test specifications? Or was this value chosen arbitrarily?
There was a problem hiding this comment.
Looks like it came from this commit to implement streaming heartbeat protocol, not sure how the value was chosen though.
|
We should document the minimum value on the options setter function. |
prestonvasquez
previously approved these changes
Oct 1, 2024
matthewdale
previously approved these changes
Oct 1, 2024
joyjwang
dismissed stale reviews from matthewdale and prestonvasquez
via
3d83d20
prestonvasquez
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-1778
Summary
The Server Monitoring spec explicitly forbids setting a heartbeatFrequencyMS of less than 500ms:
For both multi- and single-threaded drivers, the driver MUST NOT permit users to configure it less than minHeartbeatFrequencyMS (500ms).
Background & Motivation