Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 handle cases where the asset could not be scanned #197

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

chris-rock
Copy link
Member

This case can happen if we are not able to authenticate with the remove VM.

In cases as reported in #187, the packer template configured an authentication mechanism that was not supported by this provider yet. Instead of properly erroring out and reporting the issue to the user, the provider just crashed.

This change uses the cnspec improvement mondoohq/cnspec#1080 and also handles the reported errors better. This output looks as following now:

Screenshot 2024-01-31 at 15 20 00

This case can happen if we are not able to authenticate with the remove VM.
@chris-rock chris-rock merged commit 1accc80 into main Jan 31, 2024
7 checks passed
@chris-rock chris-rock deleted the chris-rock/scan-error-handling branch January 31, 2024 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant