Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Use updated reporter from cnspec #170

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Jan 10, 2024

The reporter interface changed in cnspec. This is adjusting the plugin to the new interface.

For reference: mondoohq/cnspec#982

czunker added a commit to mondoohq/cnspec that referenced this pull request Jan 10, 2024
This adds a reporter which allows to access the rendered report as bytes.Buffer.
This is needed, so we can output it inside the packer plugin.

For reference: mondoohq/packer-plugin-cnspec#170

Signed-off-by: Christian Zunker <[email protected]>
czunker added a commit to mondoohq/cnspec that referenced this pull request Jan 10, 2024
This adds a reporter which allows to access the rendered report as bytes.Buffer.
This is needed, so we can output it inside the packer plugin.

For reference: mondoohq/packer-plugin-cnspec#170

Signed-off-by: Christian Zunker <[email protected]>
czunker added a commit to mondoohq/cnspec that referenced this pull request Jan 10, 2024
This adds a reporter which allows to access the rendered report as bytes.Buffer.
This is needed, so we can output it inside the packer plugin.

For reference: mondoohq/packer-plugin-cnspec#170

Signed-off-by: Christian Zunker <[email protected]>
czunker added a commit to mondoohq/cnspec that referenced this pull request Jan 10, 2024
* 🧹 Allow to set the output for a reporter

This allows to save the rendered report as bytes.Buffer.
This is needed, so we can output it inside the packer plugin.

For reference: mondoohq/packer-plugin-cnspec#170

Signed-off-by: Christian Zunker <[email protected]>
The reporter interface changed in cnspec. This is adjusting the plugin to the new interface.

For reference: mondoohq/cnspec#982

Signed-off-by: Christian Zunker <[email protected]>
@czunker czunker marked this pull request as ready for review January 10, 2024 16:35
Copy link
Contributor

@vjeffrey vjeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@chris-rock chris-rock merged commit 3105bc6 into main Jan 10, 2024
6 checks passed
@chris-rock chris-rock deleted the christian/fix_reporter branch January 10, 2024 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants