slack policy with domain validation for users of channels #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This reverts commit c38b12a.
chris-rock
force-pushed
the
chris-rock/slack-policy
branch
from
16fb1cd
to
a05da67
Compare
tas50
reviewed
May 10, 2024
| @@ -346,3 +347,44 @@ queries: | |||
| ``` | |||
| remediation: | | |||
| Create at least one channel which is for internal workspace use only. Make sure that no user who does not belong to your organization is in the channel(s). | |||
| - uid: mondoo-slack-domain-allowlisting-enforced-on-internal-channels | |||
| title: Ensure domain is enforced on internal channels | |||
There was a problem hiding this comment.
I think we need a better description for this check. It's not totally clear what the domain we're referring to is from this title.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-adds a previous check. With the performance improvements we did, we can add the query again.