Experiments to see if LLM embeddings can recapitulate subsumption #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
February 9, 2024 10:57
…ren't of interest)
…ren't of interest)
justaddcoffee
requested review from
caufieldjh
and removed request for
cmungall
cmungall
reviewed
Feb 26, 2024
| @@ -1595,6 +1601,66 @@ def _text_lookup(obj: Dict): | |||
| db.update_collection_metadata(collection, object_type="OntologyClass") | |||
|
|
|||
|
|
|||
| @ontology.command(name="subsumption") | |||
There was a problem hiding this comment.
We should decide on one place or another. I think in the agent itself is best since this is more of a custom analysis rather than a generic command?
There was a problem hiding this comment.
sure, glad to put this where ever is best
So you mean we can get rid of the click command and just put the glue code that calls SubsumptionEvalAgent in the notebook?
There was a problem hiding this comment.
I'd be in favor of having this command available for easy results replication if lines 1647 onward go in the agent code Looked at the code again and I'm content with the current arrangement as it's already fairly generic
There was a problem hiding this comment.
+1 thanks @caufieldjh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.