Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codable encoder key strategy update #31

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

craigtweedy
Copy link
Contributor

Status

  • ✅ Ready

Type

Refactor

A code change that neither fixes a
bug nor adds a feature

Description

Swift 4.1 brought key encoding strategies, negating the need to manually specify which keys in the JSON match to properties in the object. We can now use an automatic snake_case to camelCase decoder rather than specify it manually.

gje4
gje4 previously approved these changes Dec 18, 2018
Copy link
Contributor

@gje4 gje4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@craigtweedy craigtweedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I noticed in the previous commit

Examples/moltin iOS Example/Models/CustomProduct.swift Outdated Show resolved Hide resolved
Examples/moltin iOS Example/Models/ProductCategory.swift Outdated Show resolved Hide resolved
Examples/moltin iOS Example/Models/ProductCategory.swift Outdated Show resolved Hide resolved
@craigtweedy craigtweedy dismissed gje4’s stale review December 19, 2018 13:39

New changes need reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants