Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic for adding/editing users #154

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

janash
Copy link
Member

@janash janash commented May 25, 2024

This PR updates logic on the page for adding/editing users. The main change made is that the create function is now used for creating a new user, which will result in default roles (user) and groups being set. If a user is not added to a group, a new group is created with their username.

Note that this PR is dependent on molssi-seamm/seamm_datastore#31 in the SEAMM datastore.

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 46.03%. Comparing base (104b355) to head (7003d79).
Report is 9 commits behind head on main.

Files Patch % Lines
seamm_dashboard/routes/api/users.py 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   46.62%   46.03%   -0.59%     
==========================================
  Files          35       35              
  Lines        2074     2070       -4     
==========================================
- Hits          967      953      -14     
- Misses       1107     1117      +10     
Flag Coverage Δ
unittests 46.03% <14.28%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@paulsaxe paulsaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... but what do I know? At the limits of my understanding.

@paulsaxe paulsaxe merged commit dafd1c1 into molssi-seamm:main Jun 2, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants