Fix special security level retrieval #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the config converts every key to lowercase, so let's adjust for that. Might have been caused by some update to the konf library that we missed.
urielsalis
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Arisa thought that MCL had the security level 10318, while it is actually 10502, as is specified in the config.
Approach
Apparently the config converts every key to lowercase, so convert the key to lowercase before retreiving it from the config. This might have been caused by some update to the konf library that we missed, not sure.
Future work
Change MCL on the bug tracker to use same security level as all the other projects.
Checklist
and
docsfolder