Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing variables when getting state #558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Missing variables when getting state #558

wants to merge 1 commit into from

Conversation

Nixolay
Copy link
Contributor

@Nixolay Nixolay commented Jul 8, 2020 •
edited
Loading

@Nixolay Nixolay requested a review from a team as a code owner July 8, 2020 14:52
@Nixolay Nixolay force-pushed the feature/fix_no_values_in_state branch from 3b71535 to 9dada75 Compare July 8, 2020 15:39
@coveralls
Copy link

coveralls commented Jul 8, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 80.331% when pulling ac5c6fe on feature/fix_no_values_in_state into e6d10e9 on master.

@Nixolay Nixolay force-pushed the feature/fix_no_values_in_state branch 2 times, most recently from 7232585 to 2fb0b43 Compare July 13, 2020 09:32
@Nixolay Nixolay force-pushed the feature/fix_no_values_in_state branch 4 times, most recently from 15ec8ac to ac5c6fe Compare July 23, 2020 16:10
litleleprikon
litleleprikon suggested changes Aug 4, 2020
View reviewed changes
Dockerfile.api Outdated
@@ -1,4 +1,4 @@
FROM golang:1.14.0 as builder
FROM golang:1.14.4 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason that you bump version of Go in your PR? Even if version bump is necessary I would like to see it in dedicated PR.

checker/check.go Outdated Show resolved Hide resolved
database/redis/last_check.go Outdated Show resolved Hide resolved
metric_source/local/local.go Outdated Show resolved Hide resolved
metric_source/local/local.go Outdated Show resolved Hide resolved
metric_source/local/local.go Outdated Show resolved Hide resolved
metric_source/local/local_test.go Outdated Show resolved Hide resolved
checker/fetch.go Outdated Show resolved Hide resolved
checker/fetch.go Outdated Show resolved Hide resolved
checker/fetch.go Outdated Show resolved Hide resolved
@Nixolay Nixolay added the WIP Work in progress label Aug 4, 2020
@Nixolay Nixolay force-pushed the feature/fix_no_values_in_state branch 3 times, most recently from 12bac99 to 6a32bd0 Compare August 19, 2020 07:19
fix: empty values in state
a6bba13 
* Added update of variables if they were missing
@Nixolay Nixolay force-pushed the feature/fix_no_values_in_state branch from 6a32bd0 to a6bba13 Compare August 19, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litleleprikon litleleprikon litleleprikon requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nixolay @coveralls @litleleprikon