Swap to pdm #166
Open
Swap to pdm #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moeyensj
force-pushed
the
pdm
branch
4 times, most recently
from
815dc6f
to
2de91cd
Compare
moeyensj
force-pushed
the
pdm
branch
3 times, most recently
from
9958350
to
50fcd5f
Compare
|
The last item to complete is to set the adam_core and adam_pyoorb git hashes once changes in those packages have been merged. |
akoumjian
approved these changes
Oct 11, 2024
| with: | ||
| install: true | ||
| - name: Build | ||
| run: docker build --load -t thor:$IMAGE_TAG . | ||
| - name: Lint | ||
| run: docker run -i thor:$IMAGE_TAG pre-commit run --all-files | ||
| run: docker run -i thor:$IMAGE_TAG pdm lint |
There was a problem hiding this comment.
Maybe we can dump the docker builds altogether with the simpler pyoorb / numpy install?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap to using the pdm build system.