Fix error suppression for PHP 8+

[halftrainedharry]

What does it do?

Adds a check to the custom error handler function, to see if a warning has to be handled.

Why is it needed?

MODX has a custom error handler function. When the error control operator (@) is used (e.g. @exif_read_data()), the custom error handler still gets called.

With PHP 7.4, when the error was suppressed by the @ operator, error_reporting() called inside the custom error handler always returned 0. This gets checked here:

revolution/core/src/Revolution/Error/modErrorHandler.php

Lines 61 to 63 in 9e7bb63

	if (error_reporting() == 0) {
	return false;
	}

With PHP 8, this is no longer the case:

As of PHP 8.0.0, it returns the value of this (bitwise) expression: E_ERROR | E_CORE_ERROR | E_COMPILE_ERROR | E_USER_ERROR | E_RECOVERABLE_ERROR | E_PARSE.

https://www.php.net/manual/en/language.operators.errorcontrol.php

How to test

For example:

• Use PHP 8.0 (or higher)
• Open the media browser and navigate to a folder with a picture that doesn't have EXIF headers.
• Make sure, that the warning PHP warning: exif_read_data(...): File not supported doesn't get logged to the MODX error log anymore.

Related issue(s)/PR(s)

#16420

[modxcommunity]

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/exif-read-data-file-not-supported/6572/17

[opengeek]

Excellent contribution, @halftrainedharry! I'll get this reviewed and integrated as soon as possible. I'm guessing this would also be helpful as a bug fix in 2.x.

[opengeek]

@halftrainedharry — Is this suppressing all E_WARNING errors, even if the @ operator is not used?

[halftrainedharry]

Is this suppressing all E_WARNING errors, even if the @ operator is not used?

No.

Here is a test snippet:

<?php
include MODX_CORE_PATH . "FileThatDoesntExist_01.php";
@include MODX_CORE_PATH . "FileThatDoesntExist_02.php";

include without the @ in the first line, still adds a warning to the MODX error log.

---

With error_reporting = E_ALL in the "php.ini", when include is used for a file that doesn't exist, the error handler function is called and error_reporting() in the handler function returns 32767 (= E_ALL).
When @include is used, error_reporting() in the handler function returns 4437 (= E_ERROR | E_CORE_ERROR | E_COMPILE_ERROR | E_USER_ERROR | E_RECOVERABLE_ERROR | E_PARSE).