Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect return type #16567

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix incorrect return type #16567

merged 1 commit into from
May 20, 2024

Conversation

pbowyer
Copy link
Contributor

@pbowyer pbowyer commented May 2, 2024

Correct the union of return types in documentation, so it's understood by IDEs.

What does it do?

IDEs like PhpStorm saw this method as returning only null. This change gets them to see null or mixed as the return types.

Why is it needed?

Described above.

How to test

Use this method in an IDE; confirm it doesn't have any red lines under the usages.

Related issue(s)/PR(s)

N/A

Correct the union of return types in documentation, so it's understood by IDEs.
@Ibochkarev Ibochkarev added the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label May 17, 2024
@opengeek opengeek merged commit 43ab5a2 into modxcms:3.x May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants