Log an error when resources can't be loaded in context cache generation #16508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16508 +/- ##
============================================
+ Coverage 17.95% 21.68% +3.73%
- Complexity 10442 10497 +55
============================================
Files 561 561
Lines 39051 31706 -7345
============================================
- Hits 7010 6877 -133
+ Misses 32041 24829 -7212 ☔ View full report in Codecov by Sentry. |
opengeek
approved these changes
Apr 10, 2024
opengeek
pushed a commit
that referenced
this pull request
Apr 10, 2024
### What does it do? Checks for errors loading resources in the generation of the context cache. ### Why is it needed? This is used in the aliasMap and resourceMap, but would fail silently if the query failed. In the specific case preceding this PR, the problem was a borked migration, but it took too much sleuthing to figure out where it was failing exactly due to this information not being available. ### How to test Make sure no message gets logged in normal use. ### Related issue(s)/PR(s) N/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Checks for errors loading resources in the generation of the context cache.
Why is it needed?
This is used in the aliasMap and resourceMap, but would fail silently if the query failed. In the specific case preceding this PR, the problem was a borked migration, but it took too much sleuthing to figure out where it was failing exactly due to this information not being available.
How to test
Make sure no message gets logged in normal use.
Related issue(s)/PR(s)
N/a