Fix saving time for date TVs created in MODX 2.x #16505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16505 +/- ##
=========================================
Coverage 21.68% 21.68%
- Complexity 10496 10498 +2
=========================================
Files 561 561
Lines 31703 31703
=========================================
Hits 6875 6875
Misses 24828 24828 ☔ View full report in Codecov by Sentry. |
|
Maybe it is better to prepare an upgrade script that changes the value. |
Mark-H
approved these changes
Feb 14, 2024
Ibochkarev
approved these changes
Feb 14, 2024
|
I am also fine with that solution. |
Jako
approved these changes
Feb 14, 2024
Mark-H
added
the
pr/ready-for-merging
opengeek
changed the title
opengeek
pushed a commit
that referenced
this pull request
Mar 20, 2024
### What does it do? Fixes the code in the "Resource/Create" and "Resource/Update" processors (that was added in #16398) to also work for date TVs that were created in MODX 2.x. ### Why is it needed? In MODX 2.x, the input property **"hideTime"** of a Date-TV is stored as the value "false" (or "true") -> `s:8:"hideTime";s:5:"false";` In MODX 3, the same property is stored as the value "0" (or "1") -> `s:8:"hideTime";s:1:"0";` In MODX installations, that were updated from MODX 2.x to MODX 3, the time part of the date-TV-value always gets deleted. ### How to test - Create a TV of type "date". - Change the value of "hideTime" from `s:1:"0";` to `s:5:"false";` in the column "input_properties". - Make sure, that the time part of the TV value still gets saved correctly. ### Related topic in the MODX forum https://community.modx.com/t/date-tv-time-wont-save/7335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes the code in the "Resource/Create" and "Resource/Update" processors (that was added in #16398) to also work for date TVs that were created in MODX 2.x.
Why is it needed?
In MODX 2.x, the input property "hideTime" of a Date-TV is stored as the value "false" (or "true") ->
s:8:"hideTime";s:5:"false";In MODX 3, the same property is stored as the value "0" (or "1") ->
s:8:"hideTime";s:1:"0";In MODX installations, that were updated from MODX 2.x to MODX 3, the time part of the date-TV-value always gets deleted.
How to test
s:1:"0";tos:5:"false";in the column "input_properties".Related topic in the MODX forum
https://community.modx.com/t/date-tv-time-wont-save/7335