Fix ability to view Manager Actions #16473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update permissions key to new 3.x mgr_log_view key
|
It looks like there may be some problems with the PR that prevent it from being merged. Wrapping line 37 should solve one of them. The namespace one makes no sense to me. Just changing the permission should solve the problem. Are the other changes really necessary? |
|
@BobRay - Yes, don't worry about those; the namespace one is something that'll be taken care of when another of my recent PRs gets merged that relaxes the rule that causes the error you see. The other changes are just code formatting fixes to conform to our PSR12 rules (otherwise you'd see a bunch more errors about those). |
rthrash
added
cla-signed
opengeek
pushed a commit
that referenced
this pull request
Oct 3, 2023
* Update logs controller Update permissions key to new 3.x mgr_log_view key * Code formatting update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Update view permissions key in logs controller.
Why is it needed?
The old 2.x key was still being specified in this controller, making it impossible for those without sudo permissions to view the Manager Actions log.
How to test
Test against a user having the
mgr_log_view(and without sudo permissions) to verify Manager Actions can be viewed and navigated.Related issue(s)/PR(s)
Resolves #16445