Add session garbage collector check #16448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16448 +/- ##
============================================
- Coverage 21.75% 21.68% -0.07%
- Complexity 10478 10496 +18
============================================
Files 561 561
Lines 31590 31703 +113
============================================
+ Hits 6872 6875 +3
- Misses 24718 24828 +110 ☔ View full report in Codecov by Sentry. |
Ruslan-Aleev
force-pushed
the
3.x-fix-16275
branch
from
f26eb3c
to
a6f3218
Compare
Mark-H
previously approved these changes
Aug 4, 2023
theboxer
requested changes
Oct 12, 2023
| */ | ||
| protected function _checkSessionsGarbageCollector() | ||
| { | ||
| $success = false; |
There was a problem hiding this comment.
Suggested change
| $success = false; | |
| $status = 'success'; |
Comment on lines
571
to
570
| } else { | ||
| $success = true; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else { | |
| $success = true; | |
| } | |
| } |
Comment on lines
569
to
570
| $success = @ini_set('session.gc_probability', 1); | ||
| $success = $success !== false ? true : false; |
There was a problem hiding this comment.
Suggested change
| $success = @ini_set('session.gc_probability', 1); | |
| $success = $success !== false ? true : false; | |
| $status = @ini_set('session.gc_probability', 1) !== false ? 'success' : 'fail'; |
Comment on lines
576
to
580
| if ($success) { | ||
| $this->warn('session_gc', '', $this->install->lexicon('test_session_gc_success', ['gc_probability' => $gc_probability, 'gc_divisor' => $gc_divisor])); | ||
| } else { | ||
| $this->warn('session_gc', '', $this->install->lexicon('test_session_gc_fail', ['gc_probability' => $gc_probability, 'gc_divisor' => $gc_divisor])); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if ($success) { | |
| $this->warn('session_gc', '', $this->install->lexicon('test_session_gc_success', ['gc_probability' => $gc_probability, 'gc_divisor' => $gc_divisor])); | |
| } else { | |
| $this->warn('session_gc', '', $this->install->lexicon('test_session_gc_fail', ['gc_probability' => $gc_probability, 'gc_divisor' => $gc_divisor])); | |
| } | |
| $this->warn('session_gc', '', $this->install->lexicon("test_session_gc_$status", ['gc_probability' => $gc_probability, 'gc_divisor' => $gc_divisor])); | |
Ruslan-Aleev
force-pushed
the
3.x-fix-16275
branch
from
a6f3218
to
a6a7df9
Compare
Ruslan-Aleev
force-pushed
the
3.x-fix-16275
branch
from
a6a7df9
to
b3b1df3
Compare
Ruslan-Aleev
added
the
pr/ready-for-merging
|
Do the lexicons need to be in both default.inc.php and test.inc.php? |
|
@Mark-H To be honest, I don’t know, I haven’t figured it out. Other keys are present in both files. |
opengeek
pushed a commit
that referenced
this pull request
Mar 25, 2024
### What does it do? It often happens that the `modx_session` table grows uncontrollably (I have seen up to 5 gigabytes), which sometimes leads to complete non-operation of both the site and the server. I added session garbage collector check in installer.  ### Why is it needed? That there were no problems with overflow of the table `modx_session`. ### How to test Make the installation from scratch by changing the `session.gc_probability, session.gc_divisor` parameters. ### Related issue(s)/PR(s) #16287 #16275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It often happens that the
modx_sessiontable grows uncontrollably (I have seen up to 5 gigabytes), which sometimes leads to complete non-operation of both the site and the server.I added session garbage collector check in installer.
Why is it needed?
That there were no problems with overflow of the table
modx_session.How to test
Make the installation from scratch by changing the
session.gc_probability, session.gc_divisorparameters.Related issue(s)/PR(s)
#16287
#16275