Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid filtering refactor for improved accuracy and persistence via URL parameters #16369

Merged
merged 47 commits into from
Feb 10, 2024
Merged

Grid filtering refactor for improved accuracy and persistence via URL parameters #16369

merged 47 commits into from
Feb 10, 2024

Commits on Sep 10, 2023

  1. Progress round 2, manual conflict resolution on base grid and tabs cl… 

    …asses
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    04467c6 View commit details
    Browse the repository at this point in the history

  2. Progress round 2, manual conflict resolution for usergroup acls panels

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    293e587 View commit details
    Browse the repository at this point in the history

  3. Revert "Progress round 2, manual conflict resolution on base grid and… 

    … tabs classes"

This reverts commit d70885c.
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    a99c476 View commit details
    Browse the repository at this point in the history

  4. Base class updates required for grid enhancements 

    Contains new required methods and tweaks for grid updates to follow
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    302ec13 View commit details
    Browse the repository at this point in the history

  5. Filter Persistence: Policies and Policy Templates

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2604a77 View commit details
    Browse the repository at this point in the history

  6. Filter Persistence: Deleted Resources Manager (Trash) 

    Also applied refinement to combo filter (showing only relevant Contexts) and fixed query so only deleted Resources are returned (fix from Ruslan's closed PR).
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    06af747 View commit details
    Browse the repository at this point in the history

  7. Update user group permissions, category grid 

    Applies new shared method to create the clear filters button
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    265e845 View commit details
    Browse the repository at this point in the history

  8. Update user group permissions, contexts grid 

    Applies new shared method to create the clear filters button
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    b7df565 View commit details
    Browse the repository at this point in the history

  9. Update user group permissions, namespace grid 

    Applies new shared method to create the clear filters button
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    62203a7 View commit details
    Browse the repository at this point in the history

  10. Update user group permissions, resource groups grid 

    Applies new shared method to create the clear filters button
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    df21190 View commit details
    Browse the repository at this point in the history

  11. Update user group permissions, media sources grid 

    Applies new shared method to create the clear filters button
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    dbd98a6 View commit details
    Browse the repository at this point in the history

  12. Filter Persistence: Plugin Events Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    1131e9c View commit details
    Browse the repository at this point in the history

  13. Move resource panel-specific tabchange listener 

    Since the fix is only relevant to one panel, moved it out of the Tabs base class
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    b9c9131 View commit details
    Browse the repository at this point in the history

  14. Filter Persistence: Namespaces Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    a4bf921 View commit details
    Browse the repository at this point in the history

  15. Filter Persistence: Contexts Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    010f2a7 View commit details
    Browse the repository at this point in the history

  16. Filter Persistence: Form Customization Profiles Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    6da4c35 View commit details
    Browse the repository at this point in the history

  17. Filter Persistence: Form Customization Sets Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    da11cf9 View commit details
    Browse the repository at this point in the history

  18. Filter Persistence: Dashboards Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    b41b698 View commit details
    Browse the repository at this point in the history

  19. Filter Persistence: Dashboard Widgets Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    dad621f View commit details
    Browse the repository at this point in the history

  20. Filter Persistence: Packages Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    af24d14 View commit details
    Browse the repository at this point in the history

  21. Filter Persistence: Media Sources Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    7e7bfa0 View commit details
    Browse the repository at this point in the history

  22. Update related to commit 0e0778d 

    Forgot to add this file in for Contexts panel/grid
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    b7f4d2e View commit details
    Browse the repository at this point in the history

  23. Update related to commit c7fd92b 

    Forgot to add this file
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    e4c6f4d View commit details
    Browse the repository at this point in the history

  24. Filter Persistence: Users Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    cfde395 View commit details
    Browse the repository at this point in the history

  25. Filter Persistence: Groups Panel and Users Grid 

    Note that this is the panel that appears upon first going to the ACLs. The affected grid appears when clicking on a User Group in the left tree. The grid also appears under the Users panel when editing a User Group.
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    dc219fb View commit details
    Browse the repository at this point in the history

  26. Filter Persistence: Template TVs Grid 

    Also fixes processor so the grid total count is always correct, making the paging correct and navigable.
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    77193ca View commit details
    Browse the repository at this point in the history

  27. Filter Persistence: TV Templates Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    ea98679 View commit details
    Browse the repository at this point in the history

  28. Filter Persistence: User Messages Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    c7e8bba View commit details
    Browse the repository at this point in the history

  29. Filter Persistence: Settings Grids (4) 

    Includes system settings, usergroup settings, context settings, and user settings. Also adds new method to utilities and makes minor updates for the base grid class.
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    5f40560 View commit details
    Browse the repository at this point in the history

  30. Filter Persistence: System Events Grid

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    bfc8b46 View commit details
    Browse the repository at this point in the history

  31. Filter Persistence: Lexicons Grid 

    Also provides two new helper methods in the base modLexicon class to improve filtering granularity, as well as a small styling tweak for the top toolbar.
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    9af2ea2 View commit details
    Browse the repository at this point in the history

  32. Update UserGroup Namespaces Access Grid 

    Missed adding this change to commit 504015e
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    9d8308c View commit details
    Browse the repository at this point in the history

  33. Remove Ext Statefulness from TVs Panel 

    Avoids conflicts with our new tab tracking functionality, and it's generally less confusing to have the tab panel initially show its first tab instead of the last one visited
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    fafe721 View commit details
    Browse the repository at this point in the history

  34. Minor refinements for better Extras suppport 

    Changes make identification of grid objects within a tab panel more robust/flexible
    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    53e86ff View commit details
    Browse the repository at this point in the history

  35. Fix code quality issues

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    ce7907f View commit details
    Browse the repository at this point in the history

  36. Fix one missed CQ problem

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    1ebaa55 View commit details
    Browse the repository at this point in the history

  37. Make requested review change

    Jim Graham committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    92265d1 View commit details
    Browse the repository at this point in the history

  38. Update modx.panel.template.js 

    Remove legacy filtering param
    @smg6511
    smg6511 committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    90d0047 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Required base class and utilities updates 

    New methods and fixes to address issues found in PR review
    @smg6511
    smg6511 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    91219e4 View commit details
    Browse the repository at this point in the history

  2. Settings grid updates 

    Fixes and tweaks to address PR review issues
    @smg6511
    smg6511 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    560f48e View commit details
    Browse the repository at this point in the history

  3. ACL tab content updates 

    Fixes to address PR review issue
    @smg6511
    smg6511 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    68265c2 View commit details
    Browse the repository at this point in the history

  4. Dashboards grid fixes 

    Fixes to address PR review issues
    @smg6511
    smg6511 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c1c0d23 View commit details
    Browse the repository at this point in the history

  5. ACLs - User Group Permissions fixes 

    Fixes to address PR review issues
    @smg6511
    smg6511 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d6b3bda View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Post-review fixes for system settings grids

    @smg6511
    smg6511 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1fc4312 View commit details
    Browse the repository at this point in the history

  2. Post-review fixes for packages grid 

    Adds new component id for Package grid that matches the pattern of all others ('modx-grid-[x]')
    @smg6511
    smg6511 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    dd91b49 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. UG Category tweaks 

    Minor changes made to the category filter combo to make it correctly display category names when persisted via state/URL
    @smg6511
    smg6511 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    38992d1 View commit details
    Browse the repository at this point in the history

  2. Base class updates 

    Additional logic to fix issues raised in PR review
    @smg6511
    smg6511 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    334d553 View commit details
    Browse the repository at this point in the history