Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Refine grids code to correct actions access and visibility (revised) #15919

Open
wants to merge 23 commits into
base: 3.x
Choose a base branch
from
Open

[3.x] Refine grids code to correct actions access and visibility (revised) #15919

wants to merge 23 commits into from

Commits on Sep 6, 2024

  1. Updates batch 1

    @smg6511
    Jim Graham authored and smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    cdcf096 View commit details
    Browse the repository at this point in the history

  2. Code Refinements, Batch 1 

    Made various updates in response to reviewers' feedback. (No functionality/feature changes were made.)
    @smg6511
    Jim Graham authored and smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    98fce3f View commit details
    Browse the repository at this point in the history

  3. Remove type declarations from class properties 

    Previous updates were not passing unit tests due to use of php 7.4+ feature.
    @smg6511
    Jim Graham authored and smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5182282 View commit details
    Browse the repository at this point in the history

  4. Delete index.css

    @smg6511
    Jim Graham authored and smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3128a17 View commit details
    Browse the repository at this point in the history

  5. Fix code quality issues

    @smg6511
    Jim Graham authored and smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f299d82 View commit details
    Browse the repository at this point in the history

  6. Update modMediaSource.php 

    Tiny CQ fix
    @smg6511
    Jim Graham authored and smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    77729f5 View commit details
    Browse the repository at this point in the history

  7. Resolve conflicts 

    Keeping work in progress up to date with current dev branch
    @smg6511
    smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    33492ca View commit details
    Browse the repository at this point in the history

  8. Updates batch 1

    @smg6511
    Jim Graham authored and smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dc783fb View commit details
    Browse the repository at this point in the history

  9. Code Refinements, Batch 1 

    Made various updates in response to reviewers' feedback. (No functionality/feature changes were made.)
    @smg6511
    Jim Graham authored and smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e548b58 View commit details
    Browse the repository at this point in the history

  10. Resolve conflicts 

    Keeping work in progress up to date with current dev branch
    @smg6511
    smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    004fffa View commit details
    Browse the repository at this point in the history

  11. Update modx.grid.role.js 

    Fix merge issue from last rebase
    @smg6511
    smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    08fd558 View commit details
    Browse the repository at this point in the history

  12. Update modx.grid.role.js 

    Conflict resolution
    @smg6511
    smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3b78298 View commit details
    Browse the repository at this point in the history

  13. Revert edit and remove prop names and visibility 

    Change back to public class props
    @smg6511
    smg6511 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4ab6c53 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Base js updates and default lexicon update 

    Various functionality-related changes to grid base js class and utilities lib
    @smg6511
    smg6511 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b02babe View commit details
    Browse the repository at this point in the history

  2. Context area updates 

    Various additions and optimizations, as well as code quality improvements
    @smg6511
    smg6511 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b32288a View commit details
    Browse the repository at this point in the history

  3. Media Source are updates 

    Various additions and optimizations, as well as code quality improvements
    @smg6511
    smg6511 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    239a57c View commit details
    Browse the repository at this point in the history

  4. Namespaces updates 

    Small tweaks and carry through of methods used in other core object classes to identify protected data keys
    @smg6511
    smg6511 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ad0a372 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Finalize namespaces 

    Clean up and remove creator sorting
    @smg6511
    smg6511 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a5df061 View commit details
    Browse the repository at this point in the history

  2. Finalize contexts 

    Clean up and remove creator sorting
    @smg6511
    smg6511 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a7c50b6 View commit details
    Browse the repository at this point in the history

  3. Finalize roles 

    Clean up and remove creator sorting
    @smg6511
    smg6511 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9cb63b8 View commit details
    Browse the repository at this point in the history

  4. Finalize sources 

    Clean up and remove creator sorting
    @smg6511
    smg6511 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9651b27 View commit details
    Browse the repository at this point in the history

  5. Update modx.panel.user.group.js 

    Small code formatting update
    @smg6511
    smg6511 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a36270d View commit details
    Browse the repository at this point in the history

  6. Update _utility.scss 

    Small css update for text links
    @smg6511
    smg6511 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6f2c32d View commit details
    Browse the repository at this point in the history