This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
Added user-images.githubusercontent.com to allowed hostnames. #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the hostname user-images.githubusercontent.com which is an official GitHub hostname to the allowed hostname list to resolve the issue where gifs larger than 71000000 pixels hosted on user-images.githubusercontent.com would fail to load because wsrv.nl doesn't allow gifs to be bigger than 71000000 pixels. Closes #1468
|
Looks good, but could you PR this to https://github.com/modrinth/omorphia/blob/master/lib/helpers/parse.js instead? |
|
Closing as helpers/parse.js no longer exists in knossos |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the hostname user-images.githubusercontent.com which is an official GitHub hostname to the allowed hostname list to resolve the issue where gifs larger than 71000000 pixels hosted on user-images.githubusercontent.com would fail to load because wsrv.nl doesn't allow gifs to be bigger than 71000000 pixels.
Closes modrinth/code#1478