fullscreen #360
Merged
fullscreen #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
requested changes
Jul 27, 2023
theseus/src/launcher/mod.rs
Outdated
Comment on lines
456
to
485
| // Overwrites the minecraft options.txt file with the settings from the profile | ||
| // Uses 'a:b' syntax which is not quite yaml | ||
| let options_path = instance_path.join("options.txt"); | ||
| let mut options_string = String::new(); | ||
| if options_path.exists() { | ||
| let options = io::read_to_string(&options_path).await?; | ||
| let options = options.split('\n'); | ||
| for option in options { | ||
| let option = option.split(':').collect::<Vec<_>>(); | ||
| if option.len() == 2 { | ||
| let key = option[0].trim(); | ||
| let value = option[1].trim(); | ||
| if let Some(value) = mc_set_options | ||
| .iter() | ||
| .find(|(k, _)| k == key) | ||
| .map(|(_, v)| v) | ||
| { | ||
| options_string.push_str(&format!("{}:{}\n", key, value)); | ||
| } else { | ||
| options_string.push_str(&format!("{}:{}\n", key, value)); | ||
| } | ||
| } | ||
| } | ||
| } else { | ||
| for (key, value) in mc_set_options { | ||
| options_string.push_str(&format!("{}:{}\n", key, value)); | ||
| } | ||
| } | ||
| io::write(&options_path, options_string).await?; | ||
|
|
There was a problem hiding this comment.
I don't we should overwrite the file. I think the slider should read/write from options.txt
Geometrically
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MOD-442
Improves checks for profile importing (java)