Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theseus): remove white flash when starting app #1261

Closed
wants to merge 4 commits into from

Conversation

ToBinio
Copy link
Contributor

@ToBinio ToBinio commented Jul 8, 2024

This PR should remove all the white flashes happening when starting the app. Not sure if they happened on all platforms but at least on Linux - Wayland they did.

The app only gets shown after the first render happened. This was kinda already done but it seems like the window was shown too early and the Tauri setting didn't work (at least on linux) so I had to hide it by hand.

    "windows": [
      {
        "titleBarStyle": "Overlay",
        "hiddenTitle": true,
        "fullscreen": false,
        "height": 800,
        "resizable": true,
        "title": "Modrinth App",
        "width": 1280,
        "minHeight": 700,
        "minWidth": 1100,
        "visible": false, // <- this should have hidden the window already
        "decorations": false
      }
    ]

the second fix was moving the isLoading.value = false in vue after the initialization code

reopen of #1155

@ToBinio ToBinio changed the title fix(thesues): remove white flash when starting app fix(theseus): remove white flash when starting app Jul 8, 2024
@ToBinio
Copy link
Contributor Author

ToBinio commented Aug 14, 2024

#2154 includes this

@ToBinio ToBinio closed this Aug 14, 2024
@ToBinio ToBinio deleted the fix-white-flash branch August 14, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant