Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to npm, make packaging easier for linux users #1114

Closed
wants to merge 4 commits into from

Conversation

getchoo
Copy link

@getchoo getchoo commented Apr 11, 2024

These changes are targeted towards helping out our Linux users in both using and packaging this app. This is work towards #497 - with it hopefully being the most we need to do here to the app itself - supersedes part of #559, and will help #561. Downstream PRs like flathub/flathub#4950 and NixOS/nixpkgs#289149 will also be able to take advantage of this on the next release.

The most impactful change for all platforms here will be the switch to npm. Though pnpm arguably has a better UX, it isn't supported well by most packaging systems (like nixpkgs), and in some cases not at all (flatpak); in contrast, npm is more well known and basically universally supported. Another change (exclusive to Linux) is that now all builds will be based on the latest Ubuntu LTS. This was done for two reasons:

Lastly, git dependencies have been dropped in our Node deps as they can also introduce difficulties packaging, and the .desktop file included in the deb package has much more detailed metainfo

@getchoo
Copy link
Author

getchoo commented Apr 11, 2024

@Geometrically

Geometrically added a commit that referenced this pull request Jul 4, 2024
@Geometrically Geometrically deleted the branch modrinth:master July 4, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

libssl.so.1.1 is not a dependancy in the deb
2 participants