Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug reading MT3MS-Listfiles #1899

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fixes a bug reading MT3MS-Listfiles #1899

merged 1 commit into from
Aug 3, 2023

Conversation

rabbl
Copy link
Contributor

@rabbl rabbl commented Aug 3, 2023

  • fix character span reading tkstp with a regex match
  • skip particle information reading GW-Mass Budget

@rabbl
Fixes a bug reading MT3MS-Listfiles
e8a363e 
* fix character span reading tkstp with a regex match
* skip particle information reading GW-Mass Budget
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #1899 (e8a363e) into develop (dd77e72) will decrease coverage by 0.1%.
The diff coverage is 75.0%.

@@            Coverage Diff            @@
##           develop   #1899     +/-   ##
=========================================
- Coverage     72.2%   72.2%   -0.1%     
=========================================
  Files          257     257             
  Lines        56488   56506     +18     
=========================================
+ Hits         40836   40849     +13     
- Misses       15652   15657      +5
Files Changed Coverage Δ
flopy/utils/mtlistfile.py 88.9% <75.0%> (-1.0%) ⬇️

@rabbl rabbl mentioned this pull request Aug 3, 2023
Closed
langevin-usgs
langevin-usgs approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm surprised that parsing an mt3d list file is so difficult. Seems a shame that we need a special exception if particle information is written, but nice to have this working for all cases.

@wpbonelli wpbonelli merged commit 9a22f63 into modflowpy:develop Aug 3, 2023
21 checks passed
wpbonelli pushed a commit that referenced this pull request Aug 25, 2023
@rabbl @wpbonelli
fix(mtlistfile): fix reading MT3D budget (#1899)
2222245 
* fix character span reading tkstp with a regex match
* skip particle information reading GW-Mass Budget

Co-authored-by: Ralf Junghanns <[email protected]>
@wpbonelli wpbonelli mentioned this pull request Aug 25, 2023
Merged
@wpbonelli wpbonelli mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langevin-usgs langevin-usgs langevin-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabbl @langevin-usgs @wpbonelli