QYOG-61 slack 메신저 생성 #146
Open
QYOG-61 slack 메신저 생성 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobiJeong
reviewed
Feb 23, 2024
| } | ||
|
|
||
| async sendNotification({ statusCode, exceptionError, processError }: { statusCode: number, exceptionError?: HttpInternalServerErrorException, processError?: HttpProcessErrorException }): Promise<void> { | ||
| console.log('this.webhookUrl: ', this.webhookUrl); |
| @@ -30,6 +34,7 @@ export class HttpInternalServerErrorExceptionFilter | |||
| statusCode, | |||
| exceptionError, | |||
| ); | |||
| this.slackService.sendNotification({ statusCode, exceptionError }); | |||
rrgks6221
reviewed
Feb 24, 2024
| @@ -30,6 +34,7 @@ export class HttpInternalServerErrorExceptionFilter | |||
| statusCode, | |||
| exceptionError, | |||
| ); | |||
| this.slackService.sendNotification({ statusCode, exceptionError }); | |||
| @@ -45,6 +45,7 @@ | |||
| "@nestjs/platform-express": "^10.0.0", | |||
| "@nestjs/swagger": "^7.1.16", | |||
| "@nestjs/typeorm": "^10.0.0", | |||
| "@slack/client": "^5.0.2", | |||
| @@ -56,6 +57,7 @@ | |||
| "mariadb": "^3.2.2", | |||
| "moment": "^2.30.1", | |||
| "mysql2": "^3.6.3", | |||
| "nestjs-slack-webhook": "^10.3.0", | |||
| this.webhookUrl = this.appConfigService.get<string>(ENV_KEY.SERVER_ERROR_WEB_HOOK_URL); | ||
| } | ||
|
|
||
| async sendNotification({ statusCode, exceptionError, processError }: { statusCode: number, exceptionError?: HttpInternalServerErrorException, processError?: HttpProcessErrorException }): Promise<void> { |
There was a problem hiding this comment.
매개변수를 봤을 때 일반적인 notification을 보내는게 아닌 에러시에만 노티를 보내는애같은데 input interface를 변경하거나 메서드명이 변경되면 좋을듯합니다.
| await axios.post(this.webhookUrl, { text: message }); | ||
| } catch (error) { | ||
| console.error('Error sending Slack notification:', error); | ||
| throw new Error('Failed to send Slack notification'); |
There was a problem hiding this comment.
filter영역에서 호출하는 경우 여기에 걸렸을 때 경우에따라 서버가 죽을수도있어서 console만 찍는게 나을수도있을거같습니다.
| } | ||
|
|
||
| try { | ||
| await axios.post(this.webhookUrl, { text: message }); |
There was a problem hiding this comment.
가능하면 webhook client가 사용되면 좋을거같습니다.
이유는 slack에서 제공하는 interface를 더 활용할 수 있기 때문입니다.
https://www.npmjs.com/package/@slack/webhook
| constructor( | ||
| private readonly appConfigService: AppConfigService | ||
| ) { | ||
| this.webhookUrl = this.appConfigService.get<string>(ENV_KEY.SERVER_ERROR_WEB_HOOK_URL); |
There was a problem hiding this comment.
slackGlobalService인데 url이 serverError로 고정돼는거보다는 변경될 수 있어야할거같아요.
dynamicModule로 만들거나, 메서드 매개변수로 url을 받는 방법 등이 있을거같은데 dynamicModule이 활용될 수 있으면 좋을거같긴하네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
QYOG-61
Description
500번 에러 슬랙 알림 전송 구현
To Reviewer
로 인해서 node_env로 prefix
샘플
