notice posts crud hit #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rrgks6221
reviewed
Dec 11, 2023
|
|
||
| @Module({ | ||
| imports: [ | ||
| TypeOrmExModule.forCustomRepository([NoticePostRepository]), | ||
| CommonPostsModule.forFeature(NoticePostRepository), |
There was a problem hiding this comment.
#102 에서 주입받는 방법이 변경돼서 해당 PR 반영되면 수정해서 리리퀘스트 주실 수 있나요??
@rrgks6221 추가적으로 migration 파일도 충돌나는 부분 좀 수정했습니다! |
rrgks6221
approved these changes
Dec 14, 2023
pagination key 변경은 기존 코드에 영향가지않게 작업했기 떄문에 머지해도 될듯합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
조회수 증가 기능 구현 했습니다.
To Reviewer
스웨거 문서 관련 문제도 수정 했습니다.
Reference Link
Related Issue Link
#66
API