modify/#66: modify error handling

modern-agile-team · Dec 8, 2023 · 0820ade · 0820ade
1 parent d903eaa
commit 0820ade
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/apis/free-posts/controllers/free-posts.swagger.ts b/src/apis/free-posts/controllers/free-posts.swagger.ts
@@ -12,6 +12,9 @@ import { PaginationResponseDto } from '@src/interceptors/success-interceptor/dto
 import { ApiOperator } from '@src/types/type';
 import { ValidationError } from '@src/types/validation-errors.type';
 
+/**
+ * @todo
+ */
 export const ApiFreePost: ApiOperator<keyof FreePostsController> = {
   Create: (
     apiOperationOptions: Required<Pick<Partial<OperationObject>, 'summary'>> &

diff --git a/src/apis/notice-posts/services/notice-posts.service.ts b/src/apis/notice-posts/services/notice-posts.service.ts
@@ -202,7 +202,7 @@ export class NoticePostsService {
     userId: number,
     patchUpdateNoticePostDto: PatchUpdateNoticePostDto,
   ) {
-    if (!patchUpdateNoticePostDto) {
+    if (!Object.values(patchUpdateNoticePostDto).length) {
       throw new HttpBadRequestException({
         code: COMMON_ERROR_CODE.MISSING_UPDATE_FIELD,
         errors: ['update filed is null'],