Fix loop contracts transformation when loops in branching #3640
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Oct 24, 2024
There was a problem hiding this comment.
why did you have to change this test?
There was a problem hiding this comment.
I put the first loop in a if statement, so that the test can be correctly proved only if the bug is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In loop contracts transformation, we want to visit non-loop blocks before visiting loop blocks. So we pop
loop_queueonly whenqueueis empty. We should useor_elseinstead oforwhich always pop the front ofloop_queue.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.