Fix ICE due to mishandling of Aggregate rvalue for raw pointers to trait objects #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynzech
changed the title
dyn Trait
carolynzech
changed the title
dyn Trait
celinval
approved these changes
Oct 23, 2024
zhassan-aws
approved these changes
Oct 23, 2024
|
I created #3638 to track the issue I just noticed that is unrelated to this PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a match arm for the
AggregateKind::RawPtr(TyKind::RigidTy(RigidTy::Dynamic(..)))case.Pointers to trait objects are fat, so generate a fat pointer for the rvalue.
Resolves #3631
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.