-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test the right development code (#64) #65
Conversation
@carns , would you please review and merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the suggested change to shorten the build time, can you also squash the commits in this PR please?
spack repo add ./mochi-spack-packages | ||
spack install mobject@develop+bedrock | ||
spack load mobject | ||
spack install ior@develop+mobject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could do this with one spack install line since the ior+mobject
variant will pull in bedrock already. It also looks like the build is taking over 20 minutes; I suspec that a lot of this is because it is building boost from scratch.
Maybe try spack install ior@develop+mobject ^mobject@develop+bedrock ^mercury@develop~boostsys
? I think that will do it all in one spack install command, and will tell the Mercury package to use it's own internal boost headers rather than building all of boost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carns , I get the following error if I try one liner install command for Spack:
==> Error: No version for 'mercury' satisfies '@develop-multi_recv' and '@master'
I will create a new PR. |
This PR will also test the development code with IOR.
Close #64.