Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI actions are testing the wrong code #64

Open
carns opened this issue Dec 2, 2022 · 1 comment · May be fixed by #67
Open

CI actions are testing the wrong code #64

carns opened this issue Dec 2, 2022 · 1 comment · May be fixed by #67
Assignees
@hyoklee

Comments

@carns
Copy link
Member

carns commented Dec 2, 2022

See @mdorier 's comment at #61 (comment).

The CI actions should use spack only for installing mobject dependencies, not for installing mobject itself, so that the actual mobject compilation (and make check) is executed against the correct code. See https://github.com/mochi-hpc/mochi-margo/blob/main/.github/workflows/test.yml for an example of how this is done in the mochi-margo project.
@hyoklee
Copy link
Contributor

hyoklee commented Mar 20, 2023

@carns, would you please assign this to me?

@hyoklee hyoklee mentioned this issue Mar 20, 2023
Closed
hyoklee added a commit to hyoklee/mobject that referenced this issue Apr 28, 2023
@hyoklee
ci(spack): test the right development code (mochi-hpc#64)
eb10fb7
@hyoklee hyoklee linked a pull request Apr 28, 2023 that will close this issue
Open
jhendersonHDF pushed a commit to jhendersonHDF/mobject that referenced this issue Aug 24, 2023
@hyoklee @jhendersonHDF
ci(spack): test the right development code (mochi-hpc#64)
9c2d3ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyoklee hyoklee

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hyoklee @carns