Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BMS transformations to be written to the same .h5 file #90

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Enable BMS transformations to be written to the same .h5 file #90

merged 6 commits into from
Feb 22, 2024

Conversation

keefemitman
Copy link
Contributor

[Enable BMS transformations to be written to the same .h5 as a group. This will be used for the SXS catalog, i.e., storing multiple BMS transformations in one "BMS.h5" file.

@keefemitman
Copy link
Contributor Author

@moble can you look at this quick? It should be easy.

@@ -1 +1 @@
__version__ = "2022.8.8"
__version__ = "2022.8.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What versioning is scri using? It looks like calendar versioning, so shouldn't this be 2024.02.21?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah idk what git is doing here; it does this "bump" automatically right after I push a commit

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I tried CalVer for a while, before realizing I really needed SemVer, but now we're stuck with major versions like 2022...

But the automatic bumping should only happen on release commits to main. Are you saying that this change and the CITATION.cff change were not your doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this was done automatically by git; maybe it's because I'm committing to my fork's main?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense. I'll adjust that condition.

@moble moble merged commit e2c293c into moble:main Feb 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants