-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Document Linux desktop workaround #12900
base: main
Are you sure you want to change the base?
Conversation
shouldn't we simply deploy this file ourselves on MNE startup if it doesn't exist? like we do for the MNE config file too because these steps ... nobody is gonna do this, don't you think? |
Seems too invasive to me to do it automagically. It's easy enough for people to edit and save this file if they want |
But they also need to manually download an image ... I don't know. I mean I'm okay with keeping these instructions (and thanks for writing them down!) but I'd be surprised if more than, say, 5 people will ever follow them 🤨 Meaning we'll look ugly on the vast majority of Ubuntu workstations. Not great. |
FWIW I think of things like icons and desktop files as normal/expected part of installing new GUI-based tools, so to me it doesn't seem invasive. I was assuming there was some technical limitation (permissions etc) but looking again I see that everything goes in |
Totally agree -- the installer already installs stuff here and with conda-forge/mne-feedstock#139 shortly our installers will do this. I think the discussion/suggestion @hoechenberger made is about MNE-Python itself (rather than the installer) creating files under (And as a side note, sadly there isn't an uninstaller to complement our Linux installer script but we do at least have instructions for how to uninstall manually, including the |
We're creating a config file without asking too, I don't see how this is any different For me the real question is: How do we want to present ourselves by default? Ugly with a generic icon, or pretty with a useful, identifiable icon. So it's also a question of aesthetics and accessibility Creating a small text file to achieve better aesthetics and a11y is a small price to pay IMHO |
ah oops, I missed that distinction.
it would also mean shipping a binary (logo) file in our wheel I think (not just a text file). But that aside: to me it's annoying but acceptible if a python package creates a dotted config dir in I feel like it used to be the case that matplotlib windows would get the MPL logo in the doc (just tried it and on my machine I see a blurry/pixelated version of the python snakes --- but I also just updated from 22.04 to 24.04 so maybe I'm seeing the same behavior change as @larsoner?) Anyway I bring that up because I'm on the fence, and if I knew MPL were installing |
Correct MPL also used to get a matplotlib icon and no longer does for me as well. I'm happy with escalating to their level since they think a lot harder about UI design and we can do whatever they decide |
Closes #12899