Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments for JOSS paper #111

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Address comments for JOSS paper #111

merged 1 commit into from
Aug 22, 2022

Conversation

adam2392
Copy link
Member

PR Description

Fixes: #107

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link
Member

@mscheltienne mscheltienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam2392 adam2392 merged commit aa198c4 into mne-tools:main Aug 22, 2022
@adam2392 adam2392 deleted the joss branch August 22, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JOSS] Nitpicks on the paper
2 participants