Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow latest puppet-lint version #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastelfreak
Copy link

No description provided.

@genebean
Copy link

I was just coming here to offer a similar change... hopefully this will get merged soon.

@ekohl
Copy link

ekohl commented Jan 20, 2023

@mmckinst perhaps you'd be interested in transferring the gem to Vox Pupuli if you don't have time to maintain it.

@mmckinst
Copy link
Owner

I'm trying to get permission from my employer to update it. If I'm unable to get their permission I will donate it to vox pupuli.

@danielparks
Copy link

Any update? I’m unable to update my modules with PDK because of this (which is not urgent for me, but might be an issue for others).

@mmckinst
Copy link
Owner

It has been migrated to puppet-lint directly. The code is https://github.com/puppetlabs/puppet-lint/blob/main/lib/puppet-lint/plugins/legacy_facts/legacy_facts.rb

If you upgrade to puppet-lint 3.1.0 you can delete my copy from your Gemfile.

ref #41

@danielparks
Copy link

Oh, rad. Sounds like PDK needs updating. I’ll look into it and file an issue if necessary.

@danielparks
Copy link

Issue filed: puppetlabs/pdk-templates#501

Probably the README on this repo should be updated, too. @mmckinst are there issues with your employer if I submit a PR for doing that? I understand that your hands may be tied legally and I don’t want to cause you problems.

@mmckinst
Copy link
Owner

I can update the README but no code commits yet :(.

What is the workflow for people to stop using this? Will everything just break and they'll find the README telling them to remove it?

If I do get code commits is there a way to release a new version the marks itself as obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants