Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xml:base URI resolution for RSS feeds #224

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cristoper
Copy link
Contributor

Hi mmcdole -

For completion's sake, here is a PR that enables xml:base URI resolution for the RSS parser. As I mention in the commit message, I'm not recommending to merge (without more real-world testing), but I'll keep the branch around so if anybody ever requests the feature you can point them toward it.

This enables xml:base resolution for HTML within RSS feeds.

Note:

- Relative URLs are even less common and more discouraged in RSS than they are in Atom.
- Unlike Atom, RSS does not have a good way to indicate when an element
  contains HTML. This implementation attempts to parse the contents of
  many elements as HTML (this includes the contents of `description` as
  well as `title`, `copyright`, etc.). It would probably be safer to
  limit this to description only.
- Tests only cover RSS 2 and are minimal.

I would not merge this until it is tested against some real-world RSS
and RDF feeds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant