Added fallback to atom icon when atom logo is missing #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Icon being a fallback for Feed.Image seems reasonable to me. Thanks for the contribution (and tests)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, fantastic library! 👏 Great job.
While integrating it into Feeder (my Android feed reader) one of my unit tests failed. 😞
This PR would make the test pass in my project. What do you think?
For reference, it is this assertion: https://github.com/spacecowboy/Feeder/blob/master/app/src/test/java/com/nononsenseapps/feeder/model/FeedParserTest.kt#L673
Which parses the file at: https://github.com/spacecowboy/Feeder/blob/master/app/src/test/resources/com/nononsenseapps/feeder/model/atom_cowboy.xml