fix: $detect_lost_tasks() did not work when no task was running

mlr-org · Oct 23, 2023 · efae7dc · efae7dc
1 parent 20c55e9
commit efae7dc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/R/Rush.R b/R/Rush.R
@@ -397,6 +397,7 @@ Rush = R6::R6Class("Rush",
 
       if (length(lost_workers)) {
         running_tasks = self$fetch_running_tasks(fields = "worker_extra")
+        if (!nrow(running_tasks)) return(invisible(self))
         bin_state = redux::object_to_bin(list(state = "lost"))
         keys = running_tasks[lost_workers, keys, on = "worker_id"]
 

diff --git a/tests/testthat/test-Rush.R b/tests/testthat/test-Rush.R
@@ -539,6 +539,8 @@ test_that("a lost task is detected", {
   expect_data_table(data, nrows = 1)
   expect_set_equal(data$state, "lost")
 
+  expect_class(rush$detect_lost_tasks(), "Rush")
+
   pids = rush$worker_info$pid
   expect_rush_reset(rush)
   clean_test_env(pids)