Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cb #111

Merged
merged 19 commits into from
Jul 7, 2023
Merged

Cb #111

merged 19 commits into from
Jul 7, 2023

Conversation

sebffischer
Copy link
Sponsor Member

@sebffischer sebffischer commented Jun 27, 2023

This PR:

  • Changes the CI to run once a week

  • Changes the callbacks (ctx is no longer a argument of each stage) and improves the implementation.

  • The cloneability property of a custom callback created by the user is set depending on whether a deep_clone() method was specified. (cloning an untrained learner with a custom callback is still possible)

  • Renames:

    • CallbackTorch -> CallbackSet and accordingly all related functions.

    the reason for the renaming was that previously CallbackTorch (the actual callback) and TorchCallback (the descriptor / wrapper) were easy to confuse.

  • Added tests the torch optimizer (which were previously misssing)

  • task_types no longer has a default when constructing a TorchLoss (the previous default was to use all existing task types in case nothing was specified).

  • The autotest for the parameter set was improved and test for it as well

  • Unneeded test helpers were removed

  • Added the phash methods for the PipeOps

Some TODOs that are left:

  • improve the autotest for the callback
  • Move from run_paramtest() to autotest_paramset() to also check that the defaults are specified correctly.

NOTE

@sebffischer sebffischer merged commit a8f4a7c into main Jul 7, 2023
3 checks passed
@sebffischer sebffischer deleted the cb branch July 7, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant