Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arrdist #331

Merged
merged 38 commits into from
Oct 16, 2023
Merged

Support arrdist #331

merged 38 commits into from
Oct 16, 2023

Conversation

RaphaelS1
Copy link
Collaborator

No description provided.

bblodfon and others added 3 commits September 8, 2023 10:27
@bblodfon
change input to weighted_survival_score() for Graf score + tests
d5df42d 
* Use the Matdist or Arrdist object and not the matrix or array,
same as other scores that use weighted_survival_score()
* Add tests to verify that the score didn't change
@bblodfon
add support for distr6::Arrdist prediction type
72b33ad
@RaphaelS1
Merge pull request #330 from bblodfon/main
10e48aa 
Support for `Arrdist` prediction types
bblodfon
bblodfon reviewed Sep 10, 2023
View reviewed changes
R/PredictionSurv.R Outdated Show resolved Hide resolved
bblodfon
bblodfon reviewed Sep 11, 2023
View reviewed changes
R/PredictionSurv.R Outdated Show resolved Hide resolved
bblodfon
bblodfon reviewed Sep 11, 2023
View reviewed changes
R/PredictionSurv.R Outdated Show resolved Hide resolved
@bblodfon bblodfon mentioned this pull request Sep 11, 2023
Merged
@RaphaelS1 RaphaelS1 marked this pull request as ready for review September 15, 2023 16:25
RaphaelS1
RaphaelS1 commented Sep 18, 2023
View reviewed changes
R/PredictionSurv.R Outdated Show resolved Hide resolved
RaphaelS1
RaphaelS1 commented Sep 23, 2023
View reviewed changes
R/integrated_scores.R Outdated Show resolved Hide resolved
@bblodfon
code optimization
a8306e4 
* All calls to 'weighted_survival_score' use the internal data (matrix or array)
and not the $distr interface which is slower
@bblodfon
code optimization
86dd71c 
* Do not convert to Arrdist, just extract the median survival probabilities matrix
from the 3d array
@bblodfon
test distr measures with 3d survival array
293c4c1
@bblodfon
fix R CMD check warnings
44e1551
@bblodfon
revert changes that tested graf score results numerically
33bdc13
@RaphaelS1
Copy link
Collaborator Author

dfc97f0

You might want to change which.curve = p_uty() to which.curve = p_dbl(special_vals = "median")

RaphaelS1
RaphaelS1 commented Oct 6, 2023
View reviewed changes
R/PredictionDataSurv.R Outdated Show resolved Hide resolved
RaphaelS1
RaphaelS1 commented Oct 6, 2023
View reviewed changes
R/PredictionDataSurv.R Outdated Show resolved Hide resolved
RaphaelS1
RaphaelS1 commented Oct 6, 2023
View reviewed changes
R/PredictionDataSurv.R Outdated Show resolved Hide resolved
@RaphaelS1 RaphaelS1 merged commit 76dbb0a into main Oct 16, 2023
3 of 4 checks passed
@RaphaelS1 RaphaelS1 deleted the support_arrdist branch October 16, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bblodfon bblodfon bblodfon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaphaelS1 @bblodfon