Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

started to add support for test rows #754

Closed
wants to merge 4 commits into from
Closed

Conversation

sebffischer
Copy link
Sponsor Member

@sebffischer sebffischer commented Jan 27, 2024

  • Handle the special (but most common case), where all test rows and use rows are distinct and unique. In this case, we should just be able to cbind dt[c(use, test), ] to the Task (--> requires change in mlr3). If we don't do this, and combine multiple preprocessing operations, whey will all rbind new test rows to the task.
  • Allow access to all column names in train_dt so inheriting pipeops can ensure uniqueness of columns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant