Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-numeric/date value into number/date formatted cell #206

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hnx8
Copy link

@hnx8 hnx8 commented Jul 4, 2018

  1. Partly related to using fractions in cell format gives an error when opening #189 : When specifying fraction '# ??? / ???' by format specification, it is not a source code implementation that determines cell type as 'n_numeric'. (Strictly, '#' '?' is not described to recognize it as a numeric type, but regex '/$/ absolutely determines as 'n_numeric')
  2. When assign a non-numeric value to the number formatted cell (In case I want to set a fixed text message for some reason), opening it with Excel will result in an error stating that the file has been corrupted.
  3. When assign a non-date value to the date/datetime formatted cell (In case I want to set a fixed text message for some reason), The value of the cell becomes "1900/01/01".

In order to avoid 2, 3, added processing to check the data type when setting the value in the cell.

hnx8 added 3 commits July 2, 2018 16:59
…ll instead of a numeric type cell.

Note: if not, bad numeric type cell causes "(filename.xlsx)の一部の内容に問題が見つかりました。可能な限り内容を回復しますか?" in the Japanese version of Excel.
(English version perhaps "Excel found unreadable contents in (filename.xlsx). Do you want to recover the contents of this workbook?")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant