Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Reloop Mixage MK1, MK2, Controller Edition mappings for Mixxx 2.4 #592

Open
wants to merge 29 commits into
base: 2.4
Choose a base branch
from

Conversation

HorstBaerbel
Copy link

@HorstBaerbel HorstBaerbel commented Nov 12, 2023

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some first remarks, mainly simplifications / typos

source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Dec 1, 2023

Thanks for applying all the fine tuning I suggested!
I take a final look once #12296 has been approved.

source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

@ronso0 mixxxdj/mixxx#12296 is ready, can you give this your final review?

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, the rest LGTM!

source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Sep 21, 2024

Hmm, pre-commit is complaining, please run it locally or apply the patch generated by CI
https://github.com/mixxxdj/manual/actions/runs/10973237220?pr=592

@HorstBaerbel
Copy link
Author

Hmm, pre-commit is complaining, please run it locally or apply the patch generated by CI https://github.com/mixxxdj/manual/actions/runs/10973237220?pr=592

I just applied your suggestions

@ronso0
Copy link
Member

ronso0 commented Sep 21, 2024

I know, pre-commit points to other lines, just check the patch https://github.com/mixxxdj/manual/actions/runs/10973237220/artifacts/1961733470

@HorstBaerbel
Copy link
Author

Sorry, but I've moved on to a different controller. Maybe @gqzomer can integrate this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants