Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overview example in README #74

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

rgaiacs
Copy link
Contributor

@rgaiacs rgaiacs commented Jan 9, 2024

  • export function as default
  • makeServer function take one argument

- export function as default
- makeServer function take one argument
@jneurock
Copy link
Collaborator

jneurock commented Jan 9, 2024

Thanks for the PR! Happy to include the default export in the example. What’s the rationale behind the config argument? It isn’t used in the example, right?

@rgaiacs
Copy link
Contributor Author

rgaiacs commented Jan 9, 2024

What’s the rationale behind the config argument?

Newer version of mirage (0.1.48) requires one argument. Without the argument, user encounter the follow error.

Uncaught Error: Assertion Failed: Mirage config default exported function must at least one parameter

@jneurock
Copy link
Collaborator

jneurock commented Jan 9, 2024

Oof, that’s not great but 🤷‍♂️ Thanks for taking the time to update the README!

@jneurock jneurock merged commit 0c80be1 into miragejs:main Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants