Fix parsing of ports inside the URI #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobalicek
approved these changes
Jul 12, 2024
harshavardhana
requested changes
Jul 12, 2024
balamurugana
requested changes
Jul 12, 2024
flokaiser
force-pushed
the
fix_port_parsing
branch
2 times, most recently
from
038f54f
to
6bbe61b
Compare
added 2 commits
July 12, 2024 17:00
without this change, urls like 5.my.s3.cluster were misinterpreted and the '5' parsed as the port of the url. Bug: * the getline() function puts the entire input string into the destination string, if the delimiter was not found. This leads to the entire host string being fed to the stoi() function to parse the port. Fix: * applied suggestion by @balamurugana
this flag assignement was removed in: minio#111 I don't know if it was removed intentional, but without it the BaseUrl.https flag only reflects the state of how BaseUrl was constructed with.
flokaiser
force-pushed
the
fix_port_parsing
branch
from
6bbe61b
to
8cded87
Compare
balamurugana
requested changes
Jul 13, 2024
| @@ -162,6 +162,7 @@ BaseUrl::BaseUrl(std::string host, bool https, std::string region) | |||
| return; | |||
| } | |||
|
|
|||
| this->https = url.https; | |||
There was a problem hiding this comment.
This is not correct. this->https is set in the constructor definition already.
There was a problem hiding this comment.
I have seen that, but the Url class parses the schema to set the https flag in the url class that…
Correct me if I am wrong, but if I am constructing a u=BasicUrl("https://foo.bar", false)
Then u.https is false
There was a problem hiding this comment.
Firstly BaseUrl accepts host. If URL is used, it takes only host and port. Secondly passed argument should override values. The current behavior is correct and this change is not correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this change, urls like 5.my.s3.cluster were misinterpreted and
the '5' parsed as the port of the url.
Bug:
Fix: