prepare SDK for the distributed KES implementation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
force-pushed
the
kes-dist
branch
3 times, most recently
from
aa231b7
to
ec45caf
Compare
shtripat
reviewed
Jun 23, 2023
|
Changes look good. Please check and fix lint issues |
|
PTAL @shtripat |
This commit changes the SDK w.r.t. to the upcoming distributed KES server implementation. In particular, the listing code has been changed to a paginated implementation. However, backwards compatibility with existing KES servers is maintained. Signed-off-by: Andreas Auernhammer <[email protected]>
shtripat
approved these changes
Aug 9, 2023
| @@ -38,171 +35,14 @@ type IdentityInfo struct { | |||
| Policy string // Name of the associated policy | |||
| CreatedAt time.Time // Point in time when the identity was created | |||
| CreatedBy Identity // Identity that created the identity | |||
| ExpiresAt time.Time | |||
There was a problem hiding this comment.
Is it like ExpiresAt can be later compared to now() +TTL ? What is use case of having both?
| // Policy contains a set of rules that explicitly allow | ||
| // or deny HTTP requests. | ||
| // A Rule controls HTTP requests and is part of a policy. | ||
| type Rule struct{} |
There was a problem hiding this comment.
Do we have plans to add Rule attributes or some functions later?
There was a problem hiding this comment.
Yeah, in the future we will add options to tune access control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the SDK w.r.t. to the upcoming distributed KES server implementation.
In particular, the listing code has been changed
to a paginated implementation. However, backwards
compatibility with existing KES servers is maintained.